linux-kernel - Re: [PATCH v2] x86/build: Build VSMP support only if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2073effd-4f02-c784-ca71-69ba49f51b88@suse.com>
Date:   Fri, 2 Nov 2018 08:13:07 +0100
From:   Juergen Gross <jgross@...e.com>
To:     Eial Czerwacki <eial@...lemp.com>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Randy Dunlap <rdunlap@...radead.org>,
        "Shai Fultheim (Shai@...leMP.com)" <Shai@...leMP.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "mhocko@...e.cz" <mhocko@...e.cz>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        "linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "mm-commits@...r.kernel.org" <mm-commits@...r.kernel.org>,
        X86 ML <x86@...nel.org>, Oren Twaig <oren@...lemp.com>
Subject: Re: [PATCH v2] x86/build: Build VSMP support only if CONFIG_PCI is
 selected

On 01/11/2018 19:27, Eial Czerwacki wrote:
> vsmp dependency on pv_irq_ops removed some years ago, so now let's clean
> it up from vsmp_64.c.
> 
> In short, "cap & ctl & (1 << 4)" was always returning 0, as such we can
> remove all the PARAVIRT/PARAVIRT_XXL code handling that.
> 
> However, the rest of the code depends on CONFIG_PCI, so fix it accordingly.
> in addition, rename set_vsmp_pv_ops to set_vsmp_ctl.
> 
> Signed-off-by: Eial Czerwacki <eial@...lemp.com>
> Acked-by: Shai Fultheim <shai@...lemp.com>

While I'm still thinking selection of HYPERVISOR_GUEST and PARAVIRT
is a little bit strange, you can add:

Reviewed-by: Juergen Gross <jgross@...e.com>


Juergen