linux-kernel - Re: [PATCH] Make JFFS2 endianness configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Nov 2018 10:28:49 +0100
From:   Richard Weinberger <richard.weinberger@...il.com>
To:     Joakim Tjernlund <Joakim.Tjernlund@...inera.com>
Cc:     nkela@...co.com, David Woodhouse <dwmw2@...radead.org>,
        xe-linux-external@...co.com,
        "linux-mtd @ lists . infradead . org" <linux-mtd@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>, rod@...tby.id.au
Subject: Re: [PATCH] Make JFFS2 endianness configurable

On Fri, Nov 2, 2018 at 9:46 AM Joakim Tjernlund
<Joakim.Tjernlund@...inera.com> wrote:
>
> On Thu, 2018-11-01 at 15:56 -0700, Nikunj Kela wrote:
> > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> >
> >
> > This patch allows the endianness of the JFSS2 filesystem to be
> > specified by config options.
> >
> > It defaults to native-endian (the previously hard-coded option).
> >
> > Some architectures benefit from having a single known endianness
> > of JFFS2 filesystem (for data, not executables) independent of the
> > endianness of the processor (ARM processors can be switched to either
> > endianness at run-time).
>
> I like this too. I have on several occasions needed to mount a JFFS2 BE on
> my PC. This saves me from having to hack the src.

The feature makes sense, but I don't like it being a Kconfig option.
As Al pointed out, it should be done like UFS does.

IOW, implement a wrapper function which selects the endianness automatically.
That way you can force it as mount option or detect during mount what
kind of JFFS2
you have.

-- 
Thanks,
//richard