linux-kernel - Re: [PATCH v2] drm/msm: Move fence put to where failure occurs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e882e0f-07a0-e217-6e88-082a09e87986@collabora.com>
Date:   Fri, 2 Nov 2018 13:30:48 +0100
From:   Robert Foss <robert.foss@...labora.com>
To:     Chris Wilson <chris@...is-wilson.co.uk>,
        dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/msm: Move fence put to where failure occurs

Hey Chris,

On 2018-11-02 13:16, Chris Wilson wrote:
> Quoting Robert Foss (2018-11-02 12:13:13)
>> If dma_fence_wait fails to wait for a supplied in-fence in
>> msm_ioctl_gem_submit, make sure we release that in-fence.
>>
>> Also remove this dma_fence_put() from the 'out' label.
>>
>> Signed-off-by: Robert Foss <robert.foss@...labora.com>
> 
> Reviewed-by: Chris Wilson <chris@...is-wilson.co.uk>

Danke!

> 
> Rob, this probably merits a cc:stable tag -- if the wait was interrupted
> by a signal, the fence would be leaked.

Ack, CC-ed the v2 submission.


Rob.