linux-kernel - Re: [PATCH v3 1/3] dt-bindings: connector: Add self-powered property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181102132758.GA6543@kuha.fi.intel.com>
Date:   Fri, 2 Nov 2018 15:27:58 +0200
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Badhri Jagan Sridharan <badhri@...gle.com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     Mark Rutland <mark.rutland@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Andrzej Hajda <a.hajda@...sung.com>, Li Jun <jun.li@....com>,
        linux@...ck-us.net, jackp@...eaurora.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: connector: Add self-powered property

On Mon, Oct 01, 2018 at 12:44:59PM -0700, Badhri Jagan Sridharan wrote:
> >From USB_PD_R3_0
> 7.1.5 Response to Hard Resets
> Device operation during and after a Hard Reset is defined as follows:
> Self-powered devices Should Not disconnect from USB during a Hard Reset
> (see Section 9.1.2).
> Bus powered devices will disconnect from USB during a Hard Reset due to the
> loss of their power source.
> 
> Therefore it is necessary to know whether the port belongs to
> a device which is self powered or bus powered. This change
> adds "self-powered" flag to the connector class which present indicates
> that the port belongs to a device that is self powered. Else it is
> bus powered usb device.
> 
> Signed-off-by: Badhri Jagan Sridharan <badhri@...gle.com>

Rob, I can see you acked one of the patches modifying tcpm.c in this
series, but did you mean to put the tag to this patch instead?

FWIW:

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> -------
> Changes is v3:
> - Rebase on top of usb-next
> - no change w.r.t to this patch. Same as previous versions.
> 
> No v2 version as the patch was introduced there.
> 
> ---
>  Documentation/devicetree/bindings/connector/usb-connector.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt
> index d90e17e2428b..a9a2f2fc44f2 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.txt
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt
> @@ -14,6 +14,8 @@ Optional properties:
>  - label: symbolic name for the connector,
>  - type: size of the connector, should be specified in case of USB-A, USB-B
>    non-fullsize connectors: "mini", "micro".
> +- self-powered: Set this property if the usb device that has its own power
> +  source.
>  
>  Optional properties for usb-c-connector:
>  - power-role: should be one of "source", "sink" or "dual"(DRP) if typec
> -- 
> 2.19.0.605.g01d371f741-goog

thanks,

-- 
heikki