linux-kernel - Re: [PATCH] include/asm/cmpxchg.h: Remove duplicate header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181102182905.3klrdw4dxapeoiib@tower>
Date:   Sat, 3 Nov 2018 07:29:05 +1300
From:   Michael Cree <mcree@...on.net.nz>
To:     Brajeswar Ghosh <brajeswar.linux@...il.com>
Cc:     rth@...ddle.net, ink@...assic.park.msu.ru, mattst88@...il.com,
        parri.andrea@...il.com, mingo@...nel.org,
        paulmck@...ux.vnet.ibm.com, jrdr.linux@...il.com,
        linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org,
        sabyasachi.linux@...il.com
Subject: Re: [PATCH] include/asm/cmpxchg.h: Remove duplicate header

On Fri, Nov 02, 2018 at 08:56:37PM +0530, Brajeswar Ghosh wrote:
> Remove asm/xchg.h which is included more than once
> 
> Signed-off-by: Brajeswar Ghosh <brajeswar.linux@...il.com>
> ---
>  arch/alpha/include/asm/cmpxchg.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/alpha/include/asm/cmpxchg.h b/arch/alpha/include/asm/cmpxchg.h
> index 6c7c39452471..bcbdac0744f9 100644
> --- a/arch/alpha/include/asm/cmpxchg.h
> +++ b/arch/alpha/include/asm/cmpxchg.h
> @@ -36,7 +36,6 @@
>  #undef ____cmpxchg
>  #define ____xchg(type, args...)		__xchg ##type(args)
>  #define ____cmpxchg(type, args...)	__cmpxchg ##type(args)
> -#include <asm/xchg.h>

It's amazing the number of times we get a patch to remove that.

Instead of just automatically removing a second include of a
header file, why don't you take a closer look to see what it
actually does?

Cheers,
Michael.