linux-kernel - Re: [PATCH v7 0/8] mpt3sas: some bug fixes patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Nov 2018 20:35:38 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Suganath Prabu Subramani <suganath-prabu.subramani@...adcom.com>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Sathya Prakash <Sathya.Prakash@...adcom.com>,
        Sreekanth Reddy <sreekanth.reddy@...adcom.com>
Subject: Re: [PATCH v7 0/8] mpt3sas: some bug fixes patches

On Fri, Nov 2, 2018 at 8:26 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
>
> Suganath Prabu wrote:
> > V7 Change Set:
> > Split some patches into multiple small patches
> > as suggested by Bjorn Helgaas
> >
> > v6 Change Set:
> > Incorporated changes as suggested by Andy.
> > In Patch 1 converted while loop to do while in
> > function mpt3sas_wait_for_ioc_to_operational().
> > And in patch 3 removed parentheses.
> >
> > V5 Change Set:
> > V5 post has only defect fixes.
> > We are reworking and incorporating the suggestions from Bjorn.
> > And after covering tests, we ll be post Hot-Plug Surprise
> >  removal patches.
> >
> > V4 Change Set:
> > Reframe split strings in print statement, to avoid
> >
> > V3 Change Set:
> > Simplified function "mpt3sas_base_pci_device_is_available" and
> > made inline
> >
> > V2 Change Set:
> > Replaced mpt3sas_base_pci_device_is_unplugged with
> > pci_device_is_present.
> >
> > V1 Chnage Set:
> > In Patch 0001 - unlock mutex, if active reset is in progress.
> >
> > Suganath Prabu (8):
> >   mpt3sas: Added new #define variable IOC_OPERATIONAL_WAIT_COUNT
> >   mpt3sas: Separate out mpt3sas_wait_for_ioc
> >   mpt3sas: Refactor mpt3sas_wait_for_ioc function
> >   mpt3sas: Call sas_remove_host before removing the target devices
> >   mpt3sas: Fix Sync cache command failure during driver unload
> >   mpt3sas: Don't modify EEDPTagMode field setting on SAS3.5 HBA devices
> >   mpt3sas: Fix driver modifying persistent data in Manufacturing page11
> >   mpt3sas: Bump driver version to 27.100.00.00.
> >
> >  drivers/scsi/mpt3sas/mpt3sas_base.c      | 73 +++++++++++++------------
> >  drivers/scsi/mpt3sas/mpt3sas_base.h      |  8 ++-
> >  drivers/scsi/mpt3sas/mpt3sas_config.c    | 27 ++--------
> >  drivers/scsi/mpt3sas/mpt3sas_ctl.c       | 21 ++------
> >  drivers/scsi/mpt3sas/mpt3sas_scsih.c     | 38 ++++++++++++-
> >  drivers/scsi/mpt3sas/mpt3sas_transport.c | 91 ++++++--------------------------
> >  6 files changed, 106 insertions(+), 152 deletions(-)
> >
> > --
> > 1.8.3.1
>
> These all look fine to me.  I'm only looking at the code structure; I
> have no idea how the mpt3sas hardware or the SCSI mid-layer work, so
> you're on your own there :)
>
> Reviewed-by: Bjorn Helgaas <bhelgaas@...gle.com>
>
> Andy also gave his reviewed-by on the v6 series, so I cc'd him here.
> I think it's good practice to specifically cc anybody who has
> commented on previous versions of your patch set.

Right, thanks!

With the same caveat as Bjorn posted I give my

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

to v7.


-- 
With Best Regards,
Andy Shevchenko