linux-kernel - Re: [PATCH v1 4/7] vfio: ap: AP Queue Interrupt Control VFIO ioctl calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Nov 2018 11:51:27 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Pierre Morel <pmorel@...ux.ibm.com>
Cc:     kbuild-all@...org, borntraeger@...ibm.com,
        alex.williamson@...hat.com, cohuck@...hat.com,
        linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
        kvm@...r.kernel.org, frankja@...ux.ibm.com, akrowiak@...ux.ibm.com,
        pasic@...ux.ibm.com, david@...hat.com, schwidefsky@...ibm.com,
        heiko.carstens@...ibm.com, freude@...ux.ibm.com, mimu@...ux.ibm.com
Subject: Re: [PATCH v1 4/7] vfio: ap: AP Queue Interrupt Control VFIO ioctl
 calls

Hi Pierre,

I love your patch! Yet something to improve:

[auto build test ERROR on s390/features]
[also build test ERROR on next-20181101]
[cannot apply to v4.19]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Pierre-Morel/s390-vfio-ap-Using-GISA-for-AP-Interrupt/20181102-010854
base:   https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features
config: s390-allmodconfig (attached as .config)
compiler: s390x-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=s390 

Note: the linux-review/Pierre-Morel/s390-vfio-ap-Using-GISA-for-AP-Interrupt/20181102-010854 HEAD 1235cf4914e223e3da89385619976de8eea4e9db builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   drivers/s390/crypto/vfio_ap_ops.c: In function 'ap_ioctl_setirq':
>> drivers/s390/crypto/vfio_ap_ops.c:915:18: error: 'GAL_ISC' undeclared (first use in this function); did you mean 'MAX_ISC'?
     aqic_gisa.isc = GAL_ISC;
                     ^~~~~~~
                     MAX_ISC
   drivers/s390/crypto/vfio_ap_ops.c:915:18: note: each undeclared identifier is reported only once for each function it appears in

vim +915 drivers/s390/crypto/vfio_ap_ops.c

   897	
   898	static int ap_ioctl_setirq(struct ap_matrix_mdev *matrix_mdev,
   899				   struct vfio_ap_aqic *parm)
   900	{
   901		struct aqic_gisa aqic_gisa = reg2aqic(0);
   902		struct kvm_s390_gisa *gisa = matrix_mdev->kvm->arch.gisa;
   903		struct ap_status ap_status = reg2status(0);
   904		unsigned long p;
   905		int ret = -1;
   906		int apqn;
   907		uint32_t gd;
   908	
   909		apqn = (int)(parm->cmd & 0xffff);
   910	
   911		gd = matrix_mdev->kvm->vcpus[0]->arch.sie_block->gd;
   912		if (gd & 0x01)
   913			aqic_gisa.f = 1;
   914		aqic_gisa.gisc = matrix_mdev->gisc;
 > 915		aqic_gisa.isc = GAL_ISC;
   916		aqic_gisa.ir = 1;
   917		aqic_gisa.gisao = gisa->next_alert >> 4;
   918	
   919		p = (unsigned long) page_address(matrix_mdev->map->page);
   920		p += (matrix_mdev->map->guest_addr & 0x0fff);
   921	
   922		ret = ap_host_aqic((uint64_t)apqn, aqic2reg(aqic_gisa), p);
   923		parm->status = ret;
   924	
   925		ap_status = reg2status(ret);
   926		return (ap_status.rc) ? -EIO : 0;
   927	}
   928	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (51778 bytes)