linux-kernel - Re: [PATCH v2] soc: ti: QMSS: Fix usage of irq_set_affinity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181102182231.jlyruwut3dtsfhp6@localhost>
Date:   Fri, 2 Nov 2018 11:22:31 -0700
From:   Olof Johansson <olof@...om.net>
To:     Marc Zyngier <marc.zyngier@....com>
Cc:     Santosh Shilimkar <ssantosh@...nel.org>, arm@...nel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

On Wed, Oct 31, 2018 at 08:41:34AM +0000, Marc Zyngier wrote:
> The Keystone QMSS driver is pretty damaged, in the sense that it
> does things like this:
> 
> 	irq_set_affinity_hint(irq, to_cpumask(&cpu_map));
> 
> where cpu_map is a local variable. As we leave the function, this
> will point to nowhere-land, and things will end-up badly.
> 
> Instead, let's use a proper cpumask that gets allocated, giving
> the driver a chance to actually work with things like irqbalance
> as well as have a hypothetical 64bit future.
> 
> Cc: stable@...r.kernel.org
> Acked-by: Santosh Shilimkar <ssantosh@...nel.org>
> Signed-off-by: Marc Zyngier <marc.zyngier@....com>
> ---
> * From v1:
>   - Added Santosh's Ack
>   - Cc stable
>   - Directly sent to arm-soc for immediate pick-up
>     (https://lore.kernel.org/lkml/0a20aaf3-65ce-a7ae-8a0e-877313483969@oracle.com/)

Applied to fixes, thanks. (We could have added the cc too, but thanks for doing
it!)


-Olof