linux-kernel - Re: [PATCH v2 3/4] sparc: add system call table generation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALxhOnieTqFzs-D9mNB5nL0=iPGFE92Gwm-Coft7D0_7RJgHiQ@mail.gmail.com>
Date:   Fri, 2 Nov 2018 11:09:57 +0530
From:   Firoz Khan <firoz.khan@...aro.org>
To:     "David S . Miller" <davem@...emloft.net>
Cc:     sparclinux <sparclinux@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux-Arch <linux-arch@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Marcin Juszkiewicz <marcin.juszkiewicz@...aro.org>
Subject: Re: [PATCH v2 3/4] sparc: add system call table generation support

Hi David,

On Fri, 2 Nov 2018 at 02:03, David Miller <davem@...emloft.net> wrote:
>
> From: Firoz Khan <firoz.khan@...aro.org>
> Date: Thu,  1 Nov 2018 19:23:10 +0530
>
> > +141  common  getpeername             sys_getpeername                 sys_nis_syscall
>  ...
> > +150  common  getsockname             sys_getsockname                 sys_nis_syscall
>
> The sys_nis_syscall in these two entries is incorrect, see the patch
> below.

True, The patch you mentioned here is the merged recently and I
created this patch series
few hours before that.

>
> One of my worst fears about this change has been realized, that
> instead of helping us find problems, it is so automated to the point
> that it fails to question issues like this.

Yes. I have created the system call table generation support for 10
architecture including
sparc. Every architecture I validated the generated file with replaced
one and made sure
both are same. But still I expect some human errors. The one which I
missed was caught
by respective maintainers.

BTW, the error can be raised only one time, during the development.

> If sys_nis_syscall for the compat syscall shows up in a situation where the
> native 32-bit syscall does have an entry, that's a BUG and the script should
> point this out so that the bug can be fixed.

syscall.tbl is the input to the script, so the developers has the
responsibility to fill the table
properly. I don't know, we have to write a script which has to be
smart enough to catch the
wrong syscall entries.

Thanks for your feedback.

Firoz

>
> Thank you.
>
> ====================
> From 1f2b5b8e2df4591fbca430aff9c5a072dcc0f408 Mon Sep 17 00:00:00 2001
> From: "David S. Miller" <davem@...emloft.net>
> Date: Wed, 31 Oct 2018 18:30:21 -0700
> Subject: [PATCH] sparc64: Wire up compat getpeername and getsockname.
>
> Fixes: 8b30ca73b7cc ("sparc: Add all necessary direct socket system calls.")
> Reported-by: Joseph Myers  <joseph@...esourcery.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---
>  arch/sparc/kernel/systbls_64.S | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/sparc/kernel/systbls_64.S b/arch/sparc/kernel/systbls_64.S
> index bb68c80..ff9389a 100644
> --- a/arch/sparc/kernel/systbls_64.S
> +++ b/arch/sparc/kernel/systbls_64.S
> @@ -47,9 +47,9 @@ sys_call_table32:
>         .word sys_recvfrom, sys_setreuid16, sys_setregid16, sys_rename, compat_sys_truncate
>  /*130*/        .word compat_sys_ftruncate, sys_flock, compat_sys_lstat64, sys_sendto, sys_shutdown
>         .word sys_socketpair, sys_mkdir, sys_rmdir, compat_sys_utimes, compat_sys_stat64
> -/*140*/        .word sys_sendfile64, sys_nis_syscall, compat_sys_futex, sys_gettid, compat_sys_getrlimit
> +/*140*/        .word sys_sendfile64, sys_getpeername, compat_sys_futex, sys_gettid, compat_sys_getrlimit
>         .word compat_sys_setrlimit, sys_pivot_root, sys_prctl, sys_pciconfig_read, sys_pciconfig_write
> -/*150*/        .word sys_nis_syscall, sys_inotify_init, sys_inotify_add_watch, sys_poll, sys_getdents64
> +/*150*/        .word sys_getsockname, sys_inotify_init, sys_inotify_add_watch, sys_poll, sys_getdents64
>         .word compat_sys_fcntl64, sys_inotify_rm_watch, compat_sys_statfs, compat_sys_fstatfs, sys_oldumount
>  /*160*/        .word compat_sys_sched_setaffinity, compat_sys_sched_getaffinity, sys_getdomainname, sys_setdomainname, sys_nis_syscall
>         .word sys_quotactl, sys_set_tid_address, compat_sys_mount, compat_sys_ustat, sys_setxattr
> --
> 2.1.2.532.g19b5d50
>