linux-kernel - Re: [PATCH] vbox: fix link error with 'gcc -Og'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 2 Nov 2018 20:43:04 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Kees Cook <keescook@...omium.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vbox: fix link error with 'gcc -Og'

Hi,

On 11/2/18 4:38 PM, Arnd Bergmann wrote:
> With the new CONFIG_CC_OPTIMIZE_FOR_DEBUGGING option, we get a link
> error in the vboxguest driver, when that fails to optimize out the
> call to the compat handler:
> 
> drivers/virt/vboxguest/vboxguest_core.o: In function `vbg_ioctl_hgcm_call':
> vboxguest_core.c:(.text+0x1f6e): undefined reference to `vbg_hgcm_call32'
> 
> Another compile-time check documents better what we want and avoids
> the error.
> 
> Acked-by: Randy Dunlap<rdunlap@...radead.org>
> Tested-by: Randy Dunlap<rdunlap@...radead.org>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thank you, looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans



> ---
>   drivers/virt/vboxguest/vboxguest_core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/virt/vboxguest/vboxguest_core.c b/drivers/virt/vboxguest/vboxguest_core.c
> index 3093655c7b92..1475ed5ffcde 100644
> --- a/drivers/virt/vboxguest/vboxguest_core.c
> +++ b/drivers/virt/vboxguest/vboxguest_core.c
> @@ -1312,7 +1312,7 @@ static int vbg_ioctl_hgcm_call(struct vbg_dev *gdev,
>   		return -EINVAL;
>   	}
>   
> -	if (f32bit)
> +	if (IS_ENABLED(CONFIG_COMPAT) && f32bit)
>   		ret = vbg_hgcm_call32(gdev, client_id,
>   				      call->function, call->timeout_ms,
>   				      VBG_IOCTL_HGCM_CALL_PARMS32(call),
>