linux-kernel - RE: [PATCH v3] genirq/matrix: Choose CPU for managed IRQs based on how many of them are allocated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MWHPR2101MB0729E7703751C2D393CF66B7CEC80@MWHPR2101MB0729.namprd21.prod.outlook.com>
Date:   Sat, 3 Nov 2018 23:54:30 +0000
From:   Long Li <longli@...rosoft.com>
To:     Thomas Gleixner <tglx@...utronix.de>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3] genirq/matrix: Choose CPU for managed IRQs based on
 how many of them are allocated

> Subject: Re: [PATCH v3] genirq/matrix: Choose CPU for managed IRQs based
> on how many of them are allocated
> 
> On Sat, 3 Nov 2018, Thomas Gleixner wrote:
> > On Fri, 2 Nov 2018, Long Li wrote:
> > >  /**
> > >   * irq_matrix_assign_system - Assign system wide entry in the matrix
> > >   * @m:		Matrix pointer
> > > @@ -269,7 +291,7 @@ int irq_matrix_alloc_managed(struct irq_matrix
> *m, const struct cpumask *msk,
> > >  	if (cpumask_empty(msk))
> > >  		return -EINVAL;
> > >
> > > -	cpu = matrix_find_best_cpu(m, msk);
> > > +	cpu = matrix_find_best_cpu_managed(m, msk);
> > >  	if (cpu == UINT_MAX)
> > >  		return -ENOSPC;
> > >
> > > @@ -282,6 +304,7 @@ int irq_matrix_alloc_managed(struct irq_matrix
> *m, const struct cpumask *msk,
> > >  		return -ENOSPC;
> > >  	set_bit(bit, cm->alloc_map);
> > >  	cm->allocated++;
> > > +	cm->managed_allocated++;
> > >  	m->total_allocated++;
> > >  	*mapped_cpu = cpu;
> > >  	trace_irq_matrix_alloc_managed(bit, cpu, m, cm);
> >
> > so far so good. But what exactly decrements managed_allocated ?
> 
> Another thing. If we add that counter, then it would be good to expose it in
> the debugfs files as well.

I will send an update to address those.

Long

> 
> Thanks,
> 
> 	tglx