linux-kernel - Re: [PATCH] openvswitch: fix linking without CONFIG_NF_CONNTRACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181103.192900.1832032988138355597.davem@davemloft.net>
Date:   Sat, 03 Nov 2018 19:29:00 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     pshelar@....org, pablo@...filter.org, fw@...len.de, fbl@...hat.com,
        gfree.wind@....163.com, thierry@...ystems.be, yihung.wei@...il.com,
        eswierk@...portsystems.com, Julia.Lawall@...6.fr,
        netdev@...r.kernel.org, dev@...nvswitch.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] openvswitch: fix linking without
 CONFIG_NF_CONNTRACK_LABELS

From: Arnd Bergmann <arnd@...db.de>
Date: Fri,  2 Nov 2018 16:36:55 +0100

> When CONFIG_CC_OPTIMIZE_FOR_DEBUGGING is enabled, the compiler
> fails to optimize out a dead code path, which leads to a link failure:
> 
> net/openvswitch/conntrack.o: In function `ovs_ct_set_labels':
> conntrack.c:(.text+0x2e60): undefined reference to `nf_connlabels_replace'
> 
> In this configuration, we can take a shortcut, and completely
> remove the contrack label code. This may also help the regular
> optimization.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks Arnd.