[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181104035453.GA6093@tiger>
Date: Sun, 4 Nov 2018 11:54:55 +0800
From: Shawn Guo <shawnguo@...nel.org>
To: Leonard Crestez <leonard.crestez@....com>
Cc: Lucas Stach <l.stach@...gutronix.de>,
Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
Ulf Hansson <ulf.hansson@...aro.org>,
Richard Zhu <hongxing.zhu@....com>,
Fabio Estevam <fabio.estevam@....com>,
Stefan Agner <stefan@...er.ch>, Marek Vasut <marex@...x.de>,
Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
dl-linux-imx <linux-imx@....com>,
"kernel@...gutronix.de" <kernel@...gutronix.de>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 4/4] ARM: dts: imx6sx: Add DISPLAY power domain support
On Wed, Oct 31, 2018 at 12:17:50PM +0000, Leonard Crestez wrote:
> On 10/31/2018 8:12 AM, Shawn Guo wrote:
> > On Mon, Oct 08, 2018 at 06:06:23PM +0000, Leonard Crestez wrote:
> >> This was implemented in the driver but not actually defined and
> >> referenced in dts. This makes it always on.
> >>
> >> From reference manual in section "10.4.1.4.1 Power Distribution":
> >>
> >> "Display domain - The DISPLAY domain contains GIS, CSI, PXP, LCDIF,
> >> PCIe, DCIC, and LDB. It is supplied by internal regulator."
> >>
> >> The current pd_pcie is actually only for PCIE_PHY, the PCIE ip block is
> >> actually inside the DISPLAY domain. Handle this by adding the pcie node
> >> in both power domains.
> >>
> >> Signed-off-by: Leonard Crestez <leonard.crestez@....com>
> >
> > Applied, thanks.
>
> As mentioned in the cover letter this requires multi-PD support in
> imx-pci to be implemented, specifically PATCH 3/4 of this series:
>
> https://lore.kernel.org/patchwork/patch/996810/
>
> Unless that also gets merged soon via pci I expect issues in linux-next.
> The patch already has reviewed-by tags so "merging it soon" is not
> unreasonable.
Oops, I overlooked the notes in cover-letter. Let's use the approach as
suggested there - applying the dts change after all driver dependencies
are landed.
Patch dropped, sorry.
Powered by blists - more mailing lists