linux-kernel - Re: radeon vs radeonfb Mobility quirks (Thinkpad X32)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 05 Nov 2018 10:14:57 +1100
From:   Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:     Eric Wong <e@...24.org>, David Airlie <airlied@...ux.ie>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:     linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "David (ChunMing) Zhou" <David1.Zhou@....com>
Subject: Re: radeon vs radeonfb Mobility quirks (Thinkpad X32)

On Sun, 2018-11-04 at 04:23 +0000, Eric Wong wrote:
> Looking at drivers/video/fbdev/aty/radeon_pm.c, I notice it sets
> a D2 sleep mode for my X32:
> 
>         BUGFIX("IBM Thinkpad X31/X32",
>                PCI_VENDOR_ID_IBM, 0x052f,
>                radeon_pm_d2, NULL),
> 
> Which I suspect is what allows "radeonfb" to work for me
> 
> But I can't find the corresponding quirk in drivers/gpu/drm/radeon/,
> so I now believe a missing quirk is the cause of this problem
> with the "radeon" driver.
> 
> I poked around but couldn't figure out what changes to make to
> the "radeon" driver to enable the corresponding, but I'm willing
> to test patches.
> 
> Setting "dynpm" in /sys/**/power_method didn't seem to change
> things, either.
> 
> Help greatly appreaciated.  Thanks
> 
> 
> I've mainly been using the X32 as a server this decade so didn't
> use suspend/hibernate so I didn't investigate until recently
> (because my netbook died).

There's a whole pile of power management stuff for ancient laptops that
never quite made it from radeonfb to the radeon DRM driver... sadly it
also prevents sleep on old PowerBooks but I haven't had many complaints
so...

The code for D2 and D3 on those old things is reasonably self
contained, it shouldn't be that hard to move it over I suppose.

Cheers,
Ben.