linux-kernel - Re: [alsa-devel] [PATCH] ASoC: skl: always select SND_SOC_HDAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Nov 2018 22:46:54 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc:     Takashi Iwai <tiwai@...e.de>, Arnd Bergmann <arnd@...db.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>,
        guneshwor.o.singh@...el.com, naveen.m@...el.com,
        pankaj.laxminarayan.bharadiya@...el.com,
        rakesh.a.ughreja@...el.com, sanyog.r.kale@...el.com,
        sriramx.periyasamy@...el.com, Mark Brown <broonie@...nel.org>,
        Vinod Koul <vkoul@...nel.org>, liam.r.girdwood@...ux.intel.com,
        yang.jie@...ux.intel.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA

On Mon, Nov 5, 2018 at 7:19 PM Pierre-Louis Bossart
<pierre-louis.bossart@...ux.intel.com> wrote:
>
>
> >>> We have this ("strange") lines over the drivers:
> >>>
> >>> config BAR
> >>> depends on FOO || FOO=n
> >>>
> >>> which guarantees that FOO will be not module when BAR is built-in.
> >> That's what I normally use, but I could not figure this one out.
> >> One problem is that SND_SOC_ALL_CODECS selects
> >> SND_SOC_HDAC_HDA, and SND_SOC_ALL_CODECS itself
> >> may be =m, causing the failure for
> >> SND_SOC_INTEL_SKL_HDA_DSP_GENERIC_MACH=y.
> >>
> >> It might work with a separate dummy symbol:
> >>
> >> config SND_SOC_HDAC_HDA_FORCE
> >>           tristate

> >>           depends on SND_SOC_ALL_CODECS != n

Forgot to mention that AFAIU above line is no-op in symbols which are hidden.

> >>           default SND_SOC_INTEL_SKYLAKE
> >>           select SND_SOC_HDAC_HDA


-- 
With Best Regards,
Andy Shevchenko