linux-kernel - Re: [PATCH v2 3/3] b43: Use cordic algorithm from kernel library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181105223909.61860cdd@wiggum>
Date:   Mon, 5 Nov 2018 22:39:09 +0100
From:   Michael Büsch <m@...s.ch>
To:     Priit Laes <plaes@...es.org>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-wireless@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Kalle Valo <kvalo@...eaurora.org>, b43-dev@...ts.infradead.org
Subject: Re: [PATCH v2 3/3] b43: Use cordic algorithm from kernel library

On Mon,  5 Nov 2018 21:37:18 +0200
Priit Laes <plaes@...es.org> wrote:

> Kernel library has a common cordic algorithm which is identical
> to internally implementatd one, so use it and drop the duplicate
> implementation.
> 
> Signed-off-by: Priit Laes <plaes@...es.org>


This looks nice.
But what is the testing status of this?
Has this been tested on actual b43-LP hardware?

Is the replacement algorithm exactly the same, or are there slight
differences (e.g. in corner cases)?

-- 
Michael

Content of type "application/pgp-signature" skipped