linux-kernel - Re: [PATCH v1 4/4] xtensa: generate uapi header and syscall table header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMo8BfKaSUTMT0h2jRg2ysRnc2yvVT-3=-gq6pH-XpKm1iydQQ@mail.gmail.com>
Date:   Mon, 5 Nov 2018 13:44:39 -0800
From:   Max Filippov <jcmvbkbc@...il.com>
To:     firoz.khan@...aro.org
Cc:     Chris Zankel <chris@...kel.net>, linux-xtensa@...ux-xtensa.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        y2038@...ts.linaro.org, LKML <linux-kernel@...r.kernel.org>,
        Linux-Arch <linux-arch@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>, deepa.kernel@...il.com,
        marcin.juszkiewicz@...aro.org
Subject: Re: [PATCH v1 4/4] xtensa: generate uapi header and syscall table
 header files

On Thu, Nov 1, 2018 at 6:57 AM Firoz Khan <firoz.khan@...aro.org> wrote:
>
> System call table generation script must be run to gener-
> ate unistd_32.h and syscall_table.h files. This patch will
> have changes which will invokes the script.
>
> This patch will generate unistd_32.h and syscall_table.h
> files by the syscall table generation script invoked by
> xtensa/Makefile and the generated files against the removed
> files must be identical.
>
> The generated uapi header file will be included in uapi/-
> asm/unistd.h and generated system call table header file
> will be included by kernel/syscall.c file.
>
> Signed-off-by: Firoz Khan <firoz.khan@...aro.org>
> ---
>  arch/xtensa/Makefile                  |   3 +
>  arch/xtensa/include/asm/Kbuild        |   1 +
>  arch/xtensa/include/uapi/asm/Kbuild   |   1 +
>  arch/xtensa/include/uapi/asm/unistd.h | 782 +---------------------------------
>  arch/xtensa/kernel/syscall.c          |   5 +-
>  5 files changed, 10 insertions(+), 782 deletions(-)
>
> diff --git a/arch/xtensa/Makefile b/arch/xtensa/Makefile
> index d67e30fa..1e7b179 100644
> --- a/arch/xtensa/Makefile
> +++ b/arch/xtensa/Makefile
> @@ -99,6 +99,9 @@ all Image zImage uImage: vmlinux
>  dtbs: scripts
>         $(Q)$(MAKE) $(build)=$(boot)/dts
>
> +archheaders:
> +       $(Q)$(MAKE) $(build)=arch/xtensa/kernel/syscalls all
> +
>  define archhelp
>    @echo '* Image       - Kernel ELF image with reset vector'
>    @echo '* zImage      - Compressed kernel image (arch/xtensa/boot/images/zImage.*)'
> diff --git a/arch/xtensa/include/asm/Kbuild b/arch/xtensa/include/asm/Kbuild
> index 82c75643..b35d2e6 100644
> --- a/arch/xtensa/include/asm/Kbuild
> +++ b/arch/xtensa/include/asm/Kbuild
> @@ -28,3 +28,4 @@ generic-y += topology.h
>  generic-y += trace_clock.h
>  generic-y += word-at-a-time.h
>  generic-y += xor.h
> +generic-y += syscall_table.h

This doesn't look right: syscall_table.h is not asm-generic header.

> diff --git a/arch/xtensa/include/uapi/asm/Kbuild b/arch/xtensa/include/uapi/asm/Kbuild
> index 837d4dd..f826d52 100644
> --- a/arch/xtensa/include/uapi/asm/Kbuild
> +++ b/arch/xtensa/include/uapi/asm/Kbuild
> @@ -11,3 +11,4 @@ generic-y += resource.h
>  generic-y += siginfo.h
>  generic-y += statfs.h
>  generic-y += termios.h
> +generic-y += unistd_32.h

Ditto: unistd32_.h is not asm-generic header.

-- 
Thanks.
-- Max