linux-kernel - Re: [PATCH v2 3/3] b43: Use cordic algorithm from kernel library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b536f41-6bda-712b-cd57-0034f924992a@broadcom.com>
Date:   Mon, 5 Nov 2018 23:11:17 +0100
From:   Arend van Spriel <arend.vanspriel@...adcom.com>
To:     Michael Büsch <m@...s.ch>,
        Priit Laes <plaes@...es.org>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-wireless@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Kalle Valo <kvalo@...eaurora.org>, b43-dev@...ts.infradead.org
Subject: Re: [PATCH v2 3/3] b43: Use cordic algorithm from kernel library

On 11/5/2018 10:39 PM, Michael Büsch wrote:
> On Mon,  5 Nov 2018 21:37:18 +0200
> Priit Laes <plaes@...es.org> wrote:
>
>> Kernel library has a common cordic algorithm which is identical
>> to internally implementatd one, so use it and drop the duplicate
>> implementation.
>>
>> Signed-off-by: Priit Laes <plaes@...es.org>
>
>
> This looks nice.
> But what is the testing status of this?
> Has this been tested on actual b43-LP hardware?
>
> Is the replacement algorithm exactly the same, or are there slight
> differences (e.g. in corner cases)?

Hi Michael,

I recall doing a comparison between the algorithms and thought I put 
that in the original commit message. However, it is not there. It is not 
exactly the same as in b43 so there are difference for certain angles, 
most results are the same however. This implementation is slightly more 
accurate on the full scale.