[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <3350c5dd5ea08c71e4769ea3801290e7f9238a6c.1541397462.git.sbobroff@linux.ibm.com>
Date: Mon, 5 Nov 2018 16:57:48 +1100
From: Sam Bobroff <sbobroff@...ux.ibm.com>
To: airlied@...hat.com, airlied@...ux.ie,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: [PATCH 2/2] drm/ast: Fix connector leak during driver unload
When unloading the ast driver, a warning message is printed by
drm_mode_config_cleanup() because a reference is still held to one of
the drm_connector structs.
Correct this by calling drm_framebuffer_remove() in
ast_fbdev_destroy().
Signed-off-by: Sam Bobroff <sbobroff@...ux.ibm.com>
---
drivers/gpu/drm/ast/ast_fb.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
index 0cd827e11fa2..655372ea81e9 100644
--- a/drivers/gpu/drm/ast/ast_fb.c
+++ b/drivers/gpu/drm/ast/ast_fb.c
@@ -263,6 +263,10 @@ static void ast_fbdev_destroy(struct drm_device *dev,
{
struct ast_framebuffer *afb = &afbdev->afb;
+ /* drm_framebuffer_remove() expects us to hold a ref, which it
+ * will drop, so take one: */
+ drm_framebuffer_get(&afb->base);
+ drm_framebuffer_remove(&afb->base);
drm_fb_helper_unregister_fbi(&afbdev->helper);
if (afb->obj) {
--
2.19.0.2.gcad72f5712
Powered by blists - more mailing lists