[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1541379930-14538-2-git-send-email-Anson.Huang@nxp.com>
Date: Mon, 5 Nov 2018 01:10:29 +0000
From: Anson Huang <anson.huang@....com>
To: "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
"tglx@...utronix.de" <tglx@...utronix.de>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: dl-linux-imx <linux-imx@....com>
Subject: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid
resource leak
kfree should be called to free resource in error path
before return.
Signed-off-by: Anson Huang <Anson.Huang@....com>
---
drivers/clocksource/timer-imx-gpt.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/clocksource/timer-imx-gpt.c b/drivers/clocksource/timer-imx-gpt.c
index a3d6ccb..0f78b30 100644
--- a/drivers/clocksource/timer-imx-gpt.c
+++ b/drivers/clocksource/timer-imx-gpt.c
@@ -477,12 +477,16 @@ static int __init mxc_timer_init_dt(struct device_node *np, enum imx_gpt_type t
return -ENOMEM;
imxtm->base = of_iomap(np, 0);
- if (!imxtm->base)
+ if (!imxtm->base) {
+ kfree(imxtm);
return -ENXIO;
+ }
imxtm->irq = irq_of_parse_and_map(np, 0);
- if (imxtm->irq <= 0)
+ if (imxtm->irq <= 0) {
+ kfree(imxtm);
return -EINVAL;
+ }
imxtm->clk_ipg = of_clk_get_by_name(np, "ipg");
--
2.7.4
Powered by blists - more mailing lists