[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e747d3dd-0b79-fab8-b6c1-b466113e27ce@linux.intel.com>
Date: Mon, 5 Nov 2018 15:17:12 +0800
From: Lu Baolu <baolu.lu@...ux.intel.com>
To: Christoph Hellwig <hch@...radead.org>
Cc: baolu.lu@...ux.intel.com, Joerg Roedel <joro@...tes.org>,
David Woodhouse <dwmw2@...radead.org>, kevin.tian@...el.com,
ashok.raj@...el.com,
Jean-Philippe Brucker <jean-philippe.brucker@....com>,
sanjay.k.kumar@...el.com, iommu@...ts.linux-foundation.org,
linux-kernel@...r.kernel.org, yi.y.sun@...el.com,
jacob.jun.pan@...el.com
Subject: Re: [PATCH v4 11/12] iommu/vt-d: Shared virtual address in scalable
mode
Hi,
On 11/5/18 3:15 PM, Christoph Hellwig wrote:
>> --- a/include/linux/dma_remapping.h
>> +++ b/include/linux/dma_remapping.h
>
> FYI, this file seems to be entirely VT-D specific, but has an awfully
> generic name. It should be renamed to something more suitable (or maybe
> just merged into intel-iommu.h?) and also grow some comments describing
> the contents.
>
Yes, good catch. I will do this in a separated patch.
Best regards,
Lu Baolu
Powered by blists - more mailing lists