linux-kernel - Re: [PATCHv2] ARM: dts: sun8i-h3: Add dts for the Mapleboard MP130

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181105090547.yuiblwnnpffykilg@flea>
Date:   Mon, 5 Nov 2018 10:05:47 +0100
From:   Maxime Ripard <maxime.ripard@...tlin.com>
To:     Jonathan McDowell <noodles@...th.li>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Chen-Yu Tsai <wens@...e.org>
Subject: Re: [PATCHv2] ARM: dts: sun8i-h3: Add dts for the Mapleboard MP130

On Tue, Oct 30, 2018 at 10:14:30PM +0000, Jonathan McDowell wrote:
> +	r_gpio_keys {
> +		compatible = "gpio-keys";
> +		pinctrl-names = "default";
> +
> +		power {
> +			label = "mp130:power";

That was my mistake, but it was correct in your first version.

> +&pio {
> +	leds_pio: led_pins {
> +		pins = "PA15";
> +		function = "gpio_out";
> +	};
> +};
> +
> +&r_pio {
> +	leds_r_pio: led_pins {
> +		pins = "PL10";
> +		function = "gpio_out";
> +	};
> +
> +	sw_r_pio: key_pins {
> +		pins = "PL3", "PL4";
> +		function = "gpio_in";
> +	};
> +};

You don't need these nodes at all.

I've fixed both issues and applied your patch for 4.21

Thanks!
Maxime

-- 
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)