linux-kernel - Re: [PATCH 08/11] [media] marvell-ccic/mmp: enable clock before accessing registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Nov 2018 10:17:30 +0100
From:   Pavel Machek <pavel@....cz>
To:     Lubomir Rintel <lkundrak@...sk>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Jonathan Corbet <corbet@....net>, linux-media@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        James Cameron <quozl@...top.org>
Subject: Re: [PATCH 08/11] [media] marvell-ccic/mmp: enable clock before
 accessing registers

On Mon 2018-11-05 08:30:51, Lubomir Rintel wrote:
> The access to REG_CLKCTRL or REG_CTRL1 without the clock enabled hangs
> the machine. Enable the clock first.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@...sk>

Acked-by: Pavel Machek <pavel@....cz>

> ---
>  drivers/media/platform/marvell-ccic/mmp-driver.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/platform/marvell-ccic/mmp-driver.c b/drivers/media/platform/marvell-ccic/mmp-driver.c
> index 9e988e527b0d..9c0238f72c40 100644
> --- a/drivers/media/platform/marvell-ccic/mmp-driver.c
> +++ b/drivers/media/platform/marvell-ccic/mmp-driver.c
> @@ -145,6 +145,7 @@ static int mmpcam_power_up(struct mcam_camera *mcam)
>   * Turn on power and clocks to the controller.
>   */
>  	mmpcam_power_up_ctlr(cam);
> +	mcam_clk_enable(mcam);
>  /*
>   * Provide power to the sensor.
>   */
> @@ -158,8 +159,6 @@ static int mmpcam_power_up(struct mcam_camera *mcam)
>  	gpio_set_value(pdata->sensor_reset_gpio, 1); /* reset is active low */
>  	mdelay(5);
>  
> -	mcam_clk_enable(mcam);
> -
>  	return 0;
>  }
>  

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)