linux-kernel - Re: [PATCH v3] scripts/gdb: fix lx-version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45fb570d-3703-7ed5-c831-5613fe85ba66@siemens.com>
Date:   Mon, 5 Nov 2018 10:59:49 +0100
From:   Jan Kiszka <jan.kiszka@...mens.com>
To:     kieran.bingham@...asonboard.com,
        Du Changbin <changbin.du@...il.com>, kbingham@...nel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org,
        Peter Griffin <peter.griffin@...aro.org>
Subject: Re: [PATCH v3] scripts/gdb: fix lx-version

On 25.10.18 10:54, Kieran Bingham wrote:
> Hi Du,
> 
> Thank you for the updated patch,
> 
> On 17/10/2018 15:24, Du Changbin wrote:
>> For current gdb version (has tested with 7.3 and 8.1), 'lx-version'
>> only prints one character.
>> (gdb) lx-version
>> L(gdb)
>>
>> This can be fixed by casting 'linux_banner' as (char *).
>> (gdb) lx-version
>> Linux version 4.19.0-rc1+ (changbin@...r) (gcc version 7.3.0 (Ubuntu 7.3.0-16ubuntu3)) #21 SMP Sat Sep 1 21:43:30 CST 2018
>>
>> Signed-off-by: Du Changbin <changbin.du@...il.com>
> 
> I'll update the upstream GDB bugzilla [0] regarding this issue - but I
> think we need a workaround here, and this is it.
> 
> Fixes: 2d061d999424 ("scripts/gdb: add version command")
> Reviewed-by: Kieran Bingham <kbingham@...nel.org>
> 
> And for reference, this already has an early LGTM from Jan as well.
> 
> [0] https://sourceware.org/bugzilla/show_bug.cgi?id=20077
> 

Acked-by: Jan Kiszka <jan.kiszka@...mens.com>

Jan

>> ---
>>   scripts/gdb/linux/proc.py | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py
>> index 086d27223c0c..0aebd7565b03 100644
>> --- a/scripts/gdb/linux/proc.py
>> +++ b/scripts/gdb/linux/proc.py
>> @@ -41,7 +41,7 @@ class LxVersion(gdb.Command):
>>   
>>       def invoke(self, arg, from_tty):
>>           # linux_banner should contain a newline
>> -        gdb.write(gdb.parse_and_eval("linux_banner").string())
>> +        gdb.write(gdb.parse_and_eval("(char *)linux_banner").string())
>>   
>>   LxVersion()
> 
> 

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux