linux-kernel - Re: [PATCH v2 1/3] x86: add support for Huawei WMI hotkeys.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h5zxb4wel.wl-tiwai@suse.de>
Date:   Mon, 05 Nov 2018 12:05:22 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     <ayman.bagabas@...il.com>
Cc:     "Andy Shevchenko" <andy.shevchenko@...il.com>,
        "ALSA Development Mailing List" <alsa-devel@...a-project.org>,
        "Hui Wang" <hui.wang@...onical.com>,
        "Andy Shevchenko" <andy@...radead.org>,
        "Darren Hart" <dvhart@...radead.org>,
        "Jaroslav Kysela" <perex@...ex.cz>, <kailang@...ltek.com>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        "Platform Driver" <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH v2 1/3] x86: add support for Huawei WMI hotkeys.

On Sat, 03 Nov 2018 00:10:18 +0100,
<ayman.bagabas@...il.com> wrote:
> 
> On Fri, 2018-11-02 at 20:20 +0200, Andy Shevchenko wrote:
> > > +#include <linux/input.h>
> > > +#include <linux/input/sparse-keymap.h>
> > > +#include <linux/acpi.h>
> > > +#include <linux/wmi.h>
> > 
> > Please, keep in order.
> 
> What order do I have to follow? Does this look right?
> module.h
> init.h
> apci.h
> wmi.h
> input.h
> sparse-keymap.h

A most common pattern is the alphabetical order.


thanks,

Takashi