linux-kernel - Re: [PATCH v3] ASoC: AMD: Fix race condition between register access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181105111557.GB5365@sirena.org.uk>
Date:   Mon, 5 Nov 2018 11:15:57 +0000
From:   Mark Brown <broonie@...nel.org>
To:     "Agrawal, Akshu" <Akshu.Agrawal@....com>
Cc:     "djkurtz@...omium.org" <djkurtz@...omium.org>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        "Mukunda, Vijendar" <Vijendar.Mukunda@....com>,
        Guenter Roeck <linux@...ck-us.net>,
        "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." 
        <alsa-devel@...a-project.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] ASoC: AMD: Fix race condition between register access

On Wed, Oct 31, 2018 at 09:24:10PM +0000, Agrawal, Akshu wrote:

> +/* Lock to protect access to registers */
> +static DEFINE_SPINLOCK(lock);
> +

Why is this a global variable and not a part of the driver structure?
Is there some interaction between multiple instances?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)