linux-kernel - Re: [PATCH v3 2/3] crypto: streebog - register Streebog in hash info for IMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKv+Gu-DHURWHZdyLY5Tbw5-Te-e_-89k-R91Vv3xRKchhvkYA@mail.gmail.com>
Date:   Mon, 5 Nov 2018 14:23:13 +0100
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Vitaly Chikunov <vt@...linux.org>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/3] crypto: streebog - register Streebog in hash info
 for IMA

On 24 October 2018 at 05:23, Vitaly Chikunov <vt@...linux.org> wrote:
> Register Streebog hash function in Hash Info arrays to let IMA use
> it for its purposes.
>
> Signed-off-by: Vitaly Chikunov <vt@...linux.org>
> ---
>  crypto/hash_info.c             | 4 ++++
>  include/crypto/hash_info.h     | 1 +
>  include/uapi/linux/hash_info.h | 2 ++
>  3 files changed, 7 insertions(+)
>
> diff --git a/crypto/hash_info.c b/crypto/hash_info.c
> index 7b1e0b188ce6..b0b91eb0973a 100644
> --- a/crypto/hash_info.c
> +++ b/crypto/hash_info.c
> @@ -32,6 +32,8 @@ const char *const hash_algo_name[HASH_ALGO__LAST] = {
>         [HASH_ALGO_TGR_160]     = "tgr160",
>         [HASH_ALGO_TGR_192]     = "tgr192",
>         [HASH_ALGO_SM3_256]     = "sm3-256",
> +       [HASH_ALGO_SB256]       = "sb256",
> +       [HASH_ALGO_SB512]       = "sb512",
>  };
>  EXPORT_SYMBOL_GPL(hash_algo_name);
>
> @@ -54,5 +56,7 @@ const int hash_digest_size[HASH_ALGO__LAST] = {
>         [HASH_ALGO_TGR_160]     = TGR160_DIGEST_SIZE,
>         [HASH_ALGO_TGR_192]     = TGR192_DIGEST_SIZE,
>         [HASH_ALGO_SM3_256]     = SM3256_DIGEST_SIZE,
> +       [HASH_ALGO_SB256]       = STREEBOG256_DIGEST_SIZE,
> +       [HASH_ALGO_SB512]       = STREEBOG512_DIGEST_SIZE,
>  };
>  EXPORT_SYMBOL_GPL(hash_digest_size);
> diff --git a/include/crypto/hash_info.h b/include/crypto/hash_info.h
> index 56f217d41f12..91786b68dbdb 100644
> --- a/include/crypto/hash_info.h
> +++ b/include/crypto/hash_info.h
> @@ -15,6 +15,7 @@
>
>  #include <crypto/sha.h>
>  #include <crypto/md5.h>
> +#include <crypto/streebog.h>
>
>  #include <uapi/linux/hash_info.h>
>
> diff --git a/include/uapi/linux/hash_info.h b/include/uapi/linux/hash_info.h
> index eea5d02c58de..5e8b8d952ba0 100644
> --- a/include/uapi/linux/hash_info.h
> +++ b/include/uapi/linux/hash_info.h
> @@ -33,6 +33,8 @@ enum hash_algo {
>         HASH_ALGO_TGR_160,
>         HASH_ALGO_TGR_192,
>         HASH_ALGO_SM3_256,
> +       HASH_ALGO_SB256,
> +       HASH_ALGO_SB512,

Could we make this HASH_ALGO_STREEBOG_xxx please?

>         HASH_ALGO__LAST
>  };
>
> --
> 2.11.0
>