linux-kernel - Re: [PATCH] ACPI / PMIC: xpower: fix IOSF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181105133301.GE10650@smile.fi.intel.com>
Date:   Mon, 5 Nov 2018 15:33:01 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI / PMIC: xpower: fix IOSF_MBI dependency

On Fri, Nov 02, 2018 at 11:07:34PM +0100, Arnd Bergmann wrote:
> On 11/2/18, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> > On Fri, Nov 02, 2018 at 12:06:43PM +0100, Arnd Bergmann wrote:

> >> -	depends on MFD_AXP20X_I2C && IOSF_MBI
> >> +	depends on MFD_AXP20X_I2C && IOSF_MBI=y
> >
> > To me sounds like
> >
> > select IOSF_MBI would be more appropriate here.
> 
> It looks like we have a mix of the two two, with most drivers
> using 'select' and only a few ones using 'depends on'. Mixing
> the two often leads to trouble, especially for user-visible
> symbols.
> 
> Making it a hidden symbol that is always selected is probably
> fine, but then every driver selecting it must also use 'depends
> on X86 && PCI'.

I doubt every is a correct word here. Whenever driver uses IOSF_MBI it implies
X86 and PCI (or should have those dependencies in mind already).

But I agree that hide it and select as a library would make more sense than the
current state of affairs.

-- 
With Best Regards,
Andy Shevchenko