[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181105133347.GA22485@hirez.programming.kicks-ass.net>
Date: Mon, 5 Nov 2018 14:33:47 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Nadav Amit <namit@...are.com>
Cc: Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
x86@...nel.org, "H. Peter Anvin" <hpa@...or.com>,
Thomas Gleixner <tglx@...utronix.de>,
Borislav Petkov <bp@...en8.de>,
Dave Hansen <dave.hansen@...ux.intel.com>,
Andy Lutomirski <luto@...nel.org>,
Kees Cook <keescook@...omium.org>,
Dave Hansen <dave.hansen@...el.com>,
Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH v3 2/7] x86/jump_label: Use text_poke_early() during
early_init
On Mon, Nov 05, 2018 at 01:39:53PM +0100, Peter Zijlstra wrote:
> On Fri, Nov 02, 2018 at 04:29:41PM -0700, Nadav Amit wrote:
> > diff --git a/init/main.c b/init/main.c
> > index a664246450d1..b0fa26637496 100644
> > --- a/init/main.c
> > +++ b/init/main.c
> > @@ -117,6 +117,8 @@ extern void radix_tree_init(void);
> > */
> > bool early_boot_irqs_disabled __read_mostly;
> >
> > +u8 early_boot_done __read_mostly;
> > +
> > enum system_states system_state __read_mostly;
> > EXPORT_SYMBOL(system_state);
>
> Should this not be using system_state ^ ? The site is very close to
> SYSTEM_SCHEDULING, can we use that or should we add another state ?
We must be before kernel_init() -> kernel_init_freeable() -> smp_init().
So we need another state, something like SYSTEM_BOOTING_SMP I suppose ?
> > @@ -735,6 +737,8 @@ asmlinkage __visible void __init start_kernel(void)
> > efi_free_boot_services();
> > }
> >
> > + early_boot_done = true;
> > +
> > /* Do the rest non-__init'ed, we're now alive */
> > rest_init();
> > }
> > --
> > 2.17.1
> >
Powered by blists - more mailing lists