linux-kernel - Re: [PATCH] cpufreq: imx6q: add return value check for voltage scale

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181105023152.pldy2i7rvsysijha@vireshk-i7>
Date:   Mon, 5 Nov 2018 08:01:52 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Anson Huang <anson.huang@....com>
Cc:     "rjw@...ysocki.net" <rjw@...ysocki.net>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH] cpufreq: imx6q: add return value check for voltage scale

On 05-11-18, 00:59, Anson Huang wrote:
> Add return value check for voltage scale when ARM clock
> rate change fail.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> ---
>  drivers/cpufreq/imx6q-cpufreq.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/imx6q-cpufreq.c b/drivers/cpufreq/imx6q-cpufreq.c
> index 8cfee0a..d8c3595 100644
> --- a/drivers/cpufreq/imx6q-cpufreq.c
> +++ b/drivers/cpufreq/imx6q-cpufreq.c
> @@ -160,8 +160,13 @@ static int imx6q_set_target(struct cpufreq_policy *policy, unsigned int index)
>  	/* Ensure the arm clock divider is what we expect */
>  	ret = clk_set_rate(clks[ARM].clk, new_freq * 1000);
>  	if (ret) {
> +		int ret1;
> +
>  		dev_err(cpu_dev, "failed to set clock rate: %d\n", ret);
> -		regulator_set_voltage_tol(arm_reg, volt_old, 0);
> +		ret1 = regulator_set_voltage_tol(arm_reg, volt_old, 0);
> +		if (ret1)
> +			dev_warn(cpu_dev,
> +				 "failed to restore vddarm voltage: %d\n", ret1);
>  		return ret;
>  	}
>  

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh