[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181105143818.GL10650@smile.fi.intel.com>
Date: Mon, 5 Nov 2018 16:38:18 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH 0/4] device property: Add fwnode_name() helper
On Mon, Nov 05, 2018 at 12:17:23PM +0300, Heikki Krogerus wrote:
> Hi,
>
> I prepared fwnode_name() for something I'm working on, but then I
> realized that it makes it possible to also implement a generic
> fwnode_get_named_child_node(). So in practice I'm proposing that we
> replace get_named_child_node fwnode op with that new "name" fwnode op
> in this series.
>
All LGTM, though consider one minor comment in patch 1.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> thanks,
>
> Heikki Krogerus (4):
> device property: Introduce fwnode_name()
> ACPI: property: Introduce acpi_fwnode_name()
> of/property: Introduce of_fwnode_name()
> device property: Drop get_named_child_node callback
>
> drivers/acpi/property.c | 26 +++++++-------------------
> drivers/base/property.c | 28 +++++++++++++++++++++++++++-
> drivers/of/property.c | 21 ++++++---------------
> include/linux/fwnode.h | 4 +---
> include/linux/property.h | 2 ++
> 5 files changed, 43 insertions(+), 38 deletions(-)
>
> --
> 2.19.1
>
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists