linux-kernel - Re: [PATCH 4/5] thermal: st: st_thermal: simplify getting .driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c7d3c84-c073-087e-eafb-c93bb5d43ea7@linaro.org>
Date:   Mon, 5 Nov 2018 16:06:30 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-kernel@...r.kernel.org
Cc:     linux-renesas-soc@...r.kernel.org, Zhang Rui <rui.zhang@...el.com>,
        Eduardo Valentin <edubezval@...il.com>,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH 4/5] thermal: st: st_thermal: simplify getting
 .driver_data

On 21/10/2018 22:00, Wolfram Sang wrote:
> We should get 'driver_data' from 'struct device' directly. Going via
> platform_device is an unneeded step back and forth.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

Reviewed-by: Daniel Lezcano <daniel.lezcano@...aro.org>

> ---
> 
> Build tested only. buildbot is happy.
> 
>  drivers/thermal/st/st_thermal.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/thermal/st/st_thermal.c b/drivers/thermal/st/st_thermal.c
> index be637e6b01d2..b2bbdf6eb02b 100644
> --- a/drivers/thermal/st/st_thermal.c
> +++ b/drivers/thermal/st/st_thermal.c
> @@ -277,8 +277,7 @@ EXPORT_SYMBOL_GPL(st_thermal_unregister);
>  #ifdef CONFIG_PM_SLEEP
>  static int st_thermal_suspend(struct device *dev)
>  {
> -	struct platform_device *pdev = to_platform_device(dev);
> -	struct st_thermal_sensor *sensor = platform_get_drvdata(pdev);
> +	struct st_thermal_sensor *sensor = dev_get_drvdata(dev);
>  
>  	return st_thermal_sensor_off(sensor);
>  }
> @@ -286,8 +285,7 @@ static int st_thermal_suspend(struct device *dev)
>  static int st_thermal_resume(struct device *dev)
>  {
>  	int ret;
> -	struct platform_device *pdev = to_platform_device(dev);
> -	struct st_thermal_sensor *sensor = platform_get_drvdata(pdev);
> +	struct st_thermal_sensor *sensor = dev_get_drvdata(dev);
>  
>  	ret = st_thermal_sensor_on(sensor);
>  	if (ret)
> 


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog