linux-kernel - Re: [PATCH net v2] bonding/802.3ad: fix link_failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181104.164557.2006286407522148282.davem@davemloft.net>
Date:   Sun, 04 Nov 2018 16:45:57 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jarod@...hat.com
Cc:     linux-kernel@...r.kernel.org, maheshb@...gle.com,
        netdev@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net v2] bonding/802.3ad: fix link_failure_count tracking

From: Jarod Wilson <jarod@...hat.com>
Date: Sun,  4 Nov 2018 14:59:46 -0500

> Commit 4d2c0cda07448ea6980f00102dc3964eb25e241c set slave->link to
> BOND_LINK_DOWN for 802.3ad bonds whenever invalid speed/duplex values
> were read, to fix a problem with slaves getting into weird states, but
> in the process, broke tracking of link failures, as going straight to
> BOND_LINK_DOWN when a link is indeed down (cable pulled, switch rebooted)
> means we broke out of bond_miimon_inspect()'s BOND_LINK_DOWN case because
> !link_state was already true, we never incremented commit, and never got
> a chance to call bond_miimon_commit(), where slave->link_failure_count
> would be incremented. I believe the simple fix here is to mark the slave
> as BOND_LINK_FAIL, and let bond_miimon_inspect() transition the link from
> _FAIL to either _UP or _DOWN, and in the latter case, we now get proper
> incrementing of link_failure_count again.
> 
> Fixes: 4d2c0cda0744 ("bonding: speed/duplex update at NETDEV_UP event")
> CC: Mahesh Bandewar <maheshb@...gle.com>
> CC: David S. Miller <davem@...emloft.net>
> CC: netdev@...r.kernel.org
> CC: stable@...r.kernel.org
> Signed-off-by: Jarod Wilson <jarod@...hat.com>
> ---
> v2: fix Fixes line

Applied and queued up for -stable.