linux-kernel - Re: [tip:x86/urgent] x86/vsmp: Remove dependency on pv_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c2b4c397-1789-aef0-e7fd-28abb0104c6d@scalemp.com>
Date:   Mon, 5 Nov 2018 18:40:24 +0200
From:   Eial Czerwacki <eial@...lemp.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>
Cc:     linux-kernel@...r.kernel.org, shai@...lemp.com, jgross@...e.com,
        hpa@...or.com, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/urgent] x86/vsmp: Remove dependency on pv_irq_ops

Greetings,

On 11/05/2018 05:44 PM, Thomas Gleixner wrote:
> On Mon, 5 Nov 2018, Ingo Molnar wrote:
> 
>>
>> * tip-bot for Eial Czerwacki <tipbot@...or.com> wrote:
>>
>>> Commit-ID:  7f2d7f8190d856949d8aaab55d3902cd10ea1048
>>> Gitweb:     https://git.kernel.org/tip/7f2d7f8190d856949d8aaab55d3902cd10ea1048
>>> Author:     Eial Czerwacki <eial@...lemp.com>
>>> AuthorDate: Mon, 5 Nov 2018 10:01:04 +0200
>>> Committer:  Thomas Gleixner <tglx@...utronix.de>
>>> CommitDate: Mon, 5 Nov 2018 12:33:47 +0100
>>>
>>> x86/vsmp: Remove dependency on pv_irq_ops
>>>
>>> vsmp dependency on pv_irq_ops has been removed some years ago, but the code
>>> still deals with pv_irq_ops.
>>
>> s/vsmp
>>  /vSMP
>>
>>> +#if defined CONFIG_PCI
>>
>> I don't think code was ever tested with PCI disabled?
>>
>> The above typoed sequence of code accidentally evaluates to 'true' 
>> regardless of CONFIG_PCI.
> 
> Grr. Indeed, missed that
> 
> 

actually I've tested it with CONFIG_PCI unset but evidently I've managed
to mess up the test somehow.
thanks for pointing this out, I'll send a patch that fixes it.

Eial.