linux-kernel - Re: [PATCH] ARM: mm: dump: Change to use DEFINE_SHOW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGXu5jKndtQw=RBaSFtuTRTgnET-VJpPBb2dWSJnig57GPPRrA@mail.gmail.com>
Date:   Mon, 5 Nov 2018 09:15:25 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Laura Abbott <labbott@...hat.com>
Cc:     Yangtao Li <tiny.windzz@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Jinbum Park <jinb.park7@...il.com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: mm: dump: Change to use DEFINE_SHOW_ATTRIBUTE macro

On Mon, Nov 5, 2018 at 9:01 AM, Laura Abbott <labbott@...hat.com> wrote:
> On 11/5/18 6:32 AM, Yangtao Li wrote:
>>
>> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>>
>
> Acked-by: Laura Abbott <labbott@...hat.com>
>
>
>> Signed-off-by: Yangtao Li <tiny.windzz@...il.com>
>> ---
>>   arch/arm/mm/ptdump_debugfs.c | 12 +-----------
>>   1 file changed, 1 insertion(+), 11 deletions(-)
>>
>> diff --git a/arch/arm/mm/ptdump_debugfs.c b/arch/arm/mm/ptdump_debugfs.c
>> index be8d87be4b93..201cd467a739 100644
>> --- a/arch/arm/mm/ptdump_debugfs.c
>> +++ b/arch/arm/mm/ptdump_debugfs.c
>> @@ -12,17 +12,7 @@ static int ptdump_show(struct seq_file *m, void *v)
>>         return 0;
>>   }
>>   -static int ptdump_open(struct inode *inode, struct file *file)
>> -{
>> -       return single_open(file, ptdump_show, inode->i_private);
>> -}
>> -
>> -static const struct file_operations ptdump_fops = {
>> -       .open           = ptdump_open,
>> -       .read           = seq_read,
>> -       .llseek         = seq_lseek,
>> -       .release        = single_release,
>> -};
>> +DEFINE_SHOW_ATTRIBUTE(ptdump);

Nice! Can you do the same for arch/x86/mm/debug_pagetables.c too?

Reviewed-by: Kees Cook <keescook@...omium.org>

-Kees

>>     int ptdump_debugfs_register(struct ptdump_info *info, const char
>> *name)
>>   {
>>
>



-- 
Kees Cook