linux-kernel - Re: [PATCH 1/2] firmware: add nowarn variant of request_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <60bfe247-12ca-5b1e-5b34-1f7b45ccb761@infradead.org>
Date:   Mon, 5 Nov 2018 10:35:11 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Lucas Stach <l.stach@...gutronix.de>,
        "Luis R . Rodriguez" <mcgrof@...nel.org>,
        Vinod Koul <vkoul@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        patchwork-lst@...gutronix.de, kernel@...gutronix.de
Subject: Re: [PATCH 1/2] firmware: add nowarn variant of
 request_firmware_nowait()

Hi,

typo below:

On 11/5/18 9:02 AM, Lucas Stach wrote:
> Device drivers with optional firmware may still want to use the
> asynchronous firmware loading interface. To avoid printing a
> warning into the kernel log when the optional firmware is
> absent, add a nowarn variant of this interface.
> 
> Signed-off-by: Lucas Stach <l.stach@...gutronix.de>
> ---
>  drivers/base/firmware_loader/main.c | 85 ++++++++++++++++++++---------
>  include/linux/firmware.h            | 12 ++++
>  2 files changed, 70 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c
> index 8e9213b36e31..81f4a5f6aa5b 100644
> --- a/drivers/base/firmware_loader/main.c
> +++ b/drivers/base/firmware_loader/main.c


> +/**
> + * request_firmware_nowait_nowarn() - async version of request_firmware_nowarn
> + *
> + * Similar in fucntion to request_firmware_nowait(), but doesn't print a warning

                 function

> + * when the firmware file could not be found.
> + */
> +int
> +request_firmware_nowait_nowarn(
> +	struct module *module, bool uevent,
> +	const char *name, struct device *device, gfp_t gfp, void *context,
> +	void (*cont)(const struct firmware *fw, void *context))
> +{
> +	return _request_firmware_nowait(module, uevent, name, device, gfp,
> +					context, cont, true);
> +
> +}
> +EXPORT_SYMBOL(request_firmware_nowait_nowarn);
> +
>  #ifdef CONFIG_PM_SLEEP
>  static ASYNC_DOMAIN_EXCLUSIVE(fw_cache_domain);
>  



-- 
~Randy