linux-kernel - Re: [PATCH] modsign: use all trusted keys to verify module signature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANRnR9Qs0wjAprhLzNTg1COLyyh9pcv_SxtZnKBoadED0RJVjg@mail.gmail.com>
Date:   Mon, 5 Nov 2018 11:13:17 -0800
From:   Ke Wu <mikewu@...gle.com>
To:     jeyu@...nel.org
Cc:     dhowells@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] modsign: use all trusted keys to verify module signature

Hi, I'm wondering if there is any update for the patch.

Thanks!

On Wed, Oct 31, 2018 at 2:36 AM Jessica Yu <jeyu@...nel.org> wrote:
>
> +++ Ke Wu [22/10/18 15:26 -0700]:
> >Make mod_verify_sig to use all trusted keys. This allows keys in
> >secondary_trusted_keys to be used to verify PKCS#7 signature on a
> >kernel module.
> >
> >Signed-off-by: Ke Wu <mikewu@...gle.com>
>
> Thanks for the ping, I had missed this patch.
>
> David, could I get an ACK please?
>
> Thanks!
>
> Jessica
>
> >---
> > kernel/module_signing.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/kernel/module_signing.c b/kernel/module_signing.c
> >index f2075ce8e4b3..a8b923ba1a39 100644
> >--- a/kernel/module_signing.c
> >+++ b/kernel/module_signing.c
> >@@ -83,6 +83,6 @@ int mod_verify_sig(const void *mod, struct load_info *info)
> >       }
> >
> >       return verify_pkcs7_signature(mod, modlen, mod + modlen, sig_len,
> >-                                    NULL, VERIFYING_MODULE_SIGNATURE,
> >+                                    (void *)1UL, VERIFYING_MODULE_SIGNATURE,
> >                                     NULL, NULL);
> > }
> >--
> >2.19.1.568.g152ad8e336-goog
> >



-- 
Ke Wu | Software Engineer | mikewu@...gle.com | Google Inc.