linux-kernel - Re: [PATCH v3 01/16] tpm: use tpm_buf in tpm_transmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181106055250.GB15575@linux.intel.com>
Date:   Tue, 6 Nov 2018 07:52:50 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Stefan Berger <stefanb@...ux.ibm.com>
Cc:     linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        James Bottomley <James.Bottomley@...senPartnership.com>,
        Tomas Winkler <tomas.winkler@...el.com>,
        Tadeusz Struk <tadeusz.struk@...el.com>,
        Stefan Berger <stefanb@...ux.vnet.ibm.com>,
        Nayna Jain <nayna@...ux.ibm.com>,
        Peter Huewe <peterhuewe@....de>,
        Jason Gunthorpe <jgg@...pe.ca>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 01/16] tpm: use tpm_buf in tpm_transmit_cmd() as the
 IO parameter

On Mon, Nov 05, 2018 at 04:48:13PM -0500, Stefan Berger wrote:
> >   int tpm_send(struct tpm_chip *chip, void *cmd, size_t buflen)
> >   {
> > +	struct tpm_buf buf;
> >   	int rc;
> > 
> >   	chip = tpm_find_get_ops(chip);
> >   	if (!chip)
> >   		return -ENODEV;
> > 
> > -	rc = tpm_transmit_cmd(chip, NULL, cmd, buflen, 0, 0,
> > +	rc = tpm_buf_init(&buf, 0, 0);
> > +	if (rc)
> > +		goto out;
> > +
> > +	memcpy(buf.data, cmd, buflen);
> 
> 
> Nit: buflen -> cmd_len

Agreed that it should but I try to keep the patch as minimal and
mechanical as I can.

Thank you.

/Jarkko