linux-kernel - Re: [PATCH] lib/raid6: Fix arm64 test build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKv+Gu_i_Oaee_JTEuVd+yVsSzj-_ULUKp_NmMGT3Xh+oQBZKw@mail.gmail.com>
Date:   Tue, 6 Nov 2018 09:16:04 +0100
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Jeremy Linton <jeremy.linton@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        matthew.brown.dev@...il.com, Michael Ellerman <mpe@...erman.id.au>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] lib/raid6: Fix arm64 test build

(+ Catalin, Will)

On 6 November 2018 at 01:14, Jeremy Linton <jeremy.linton@....com> wrote:
> The lib/raid6/test fails to build the neon objects
> on arm64 because the correct machine type is 'aarch64'.
>
> Once this is correctly enabled, the neon recovery objects
> need to be added to the build.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@....com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>

> ---
>  lib/raid6/test/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/raid6/test/Makefile b/lib/raid6/test/Makefile
> index 5d73f5cb4d8a..79777645cac9 100644
> --- a/lib/raid6/test/Makefile
> +++ b/lib/raid6/test/Makefile
> @@ -27,7 +27,7 @@ ifeq ($(ARCH),arm)
>          CFLAGS += -I../../../arch/arm/include -mfpu=neon
>          HAS_NEON = yes
>  endif
> -ifeq ($(ARCH),arm64)
> +ifeq ($(ARCH),aarch64)
>          CFLAGS += -I../../../arch/arm64/include
>          HAS_NEON = yes
>  endif
> @@ -41,7 +41,7 @@ ifeq ($(IS_X86),yes)
>                     gcc -c -x assembler - >&/dev/null &&        \
>                     rm ./-.o && echo -DCONFIG_AS_AVX512=1)
>  else ifeq ($(HAS_NEON),yes)
> -        OBJS   += neon.o neon1.o neon2.o neon4.o neon8.o
> +        OBJS   += neon.o neon1.o neon2.o neon4.o neon8.o recov_neon.o recov_neon_inner.o
>          CFLAGS += -DCONFIG_KERNEL_MODE_NEON=1
>  else
>          HAS_ALTIVEC := $(shell printf '\#include <altivec.h>\nvector int a;\n' |\
> --
> 2.17.2
>