linux-kernel - RE: [PATCH] drm/syncobj: Fix oops on drm_syncobj_find_fence(file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY1PR12MB050299A6BA4B1967250724AAB4CB0@BY1PR12MB0502.namprd12.prod.outlook.com>
Date:   Tue, 6 Nov 2018 02:18:38 +0000
From:   "Zhou, David(ChunMing)" <David1.Zhou@....com>
To:     Eric Anholt <eric@...olt.net>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Koenig, Christian" <Christian.Koenig@....com>
Subject: RE: [PATCH] drm/syncobj: Fix oops on
 drm_syncobj_find_fence(file_priv, 0, ...).

Reviewed-by: Chunming Zhou <david1.zhou@....com>

> -----Original Message-----
> From: Eric Anholt <eric@...olt.net>
> Sent: Tuesday, November 06, 2018 7:01 AM
> To: dri-devel@...ts.freedesktop.org
> Cc: linux-kernel@...r.kernel.org; Eric Anholt <eric@...olt.net>; Zhou,
> David(ChunMing) <David1.Zhou@....com>; Koenig, Christian
> <Christian.Koenig@....com>
> Subject: [PATCH] drm/syncobj: Fix oops on
> drm_syncobj_find_fence(file_priv, 0, ...).
> 
> This broke rendering on V3D, where we almost always have a 0 in-syncobj.
> 
> Signed-off-by: Eric Anholt <eric@...olt.net>
> Fixes: 48197bc564c7 ("drm: add syncobj timeline support v9")
> Cc: Chunming Zhou <david1.zhou@....com>
> Cc: Christian König <christian.koenig@....com>
> ---
>  drivers/gpu/drm/drm_syncobj.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_syncobj.c
> b/drivers/gpu/drm/drm_syncobj.c index 4dca5f7e8c4b..da8175d9c6ff 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -443,7 +443,8 @@ int drm_syncobj_find_fence(struct drm_file
> *file_private,
>  	int ret;
> 
>  	ret = drm_syncobj_search_fence(syncobj, point, flags, fence);
> -	drm_syncobj_put(syncobj);
> +	if (syncobj)
> +		drm_syncobj_put(syncobj);
>  	return ret;
>  }
>  EXPORT_SYMBOL(drm_syncobj_find_fence);
> --
> 2.19.1