linux-kernel - Re: [PATCH] mips: delete duplication of BUILTIN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMT6-xji=XrteXm6KbUYLiKqSH_-RHzXzwn3zi5hYbtq_R_sRg@mail.gmail.com>
Date:   Tue, 6 Nov 2018 17:29:40 +0200
From:   Maksym Kokhan <maksym.kokhan@...ballogic.com>
To:     geert@...ux-m68k.org
Cc:     sergei.shtylyov@...entembedded.com,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paul.burton@...s.com>,
        James Hogan <jhogan@...nel.org>,
        Andrii Bordunov <andrew.bordunov@...il.com>,
        linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mips: delete duplication of BUILTIN_DTB selection

On Thu, Oct 4, 2018 at 3:06 PM Maksym Kokhan
<maksym.kokhan@...ballogic.com> wrote:
>
> On Thu, Oct 4, 2018 at 12:14 PM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> >
> > On Thu, Oct 4, 2018 at 10:38 AM Sergei Shtylyov
> > <sergei.shtylyov@...entembedded.com> wrote:
> > > On 10/3/2018 8:23 PM, Maksym Kokhan wrote:
> > > > CONFIG_BUILTIN_DTB selection is duplicated in menu
> > > > "Machine selection" under MIPS_MALTA.
> > > >
> > > > Fixes: e81a8c7dabac ("MIPS: Malta: Setup RAM regions via DT")
> > > > Signed-off-by: Maksym Kokhan <maksym.kokhan@...ballogic.com>
> > > > Signed-off-by: Andrii Bordunov <andrew.bordunov@...il.com>
> > > > ---
> > > >   arch/mips/Kconfig | 1 -
> > > >   1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > > > index 3551199..71d6549 100644
> > > > --- a/arch/mips/Kconfig
> > > > +++ b/arch/mips/Kconfig
> > > > @@ -539,7 +539,6 @@ config MIPS_MALTA
> > > >       select USE_OF
> > > >       select LIBFDT
> > > >       select ZONE_DMA32 if 64BIT
> > > > -     select BUILTIN_DTB
> > > >       select LIBFDT
> > >
> > >     LIBFDT seems duplicated too.
> >
> > Using random sort order doesn't help. Keep them sorted, please?
>
> We are going to deal with it in the separate patch.

Is it OK to leave this patch as it is and make another patch/patches
for other changes or it would be better to modify it to remove
duplication of LIBFDT too and sort this list of configs?

--
Regards,
Maksym Kokhan