linux-kernel - Re: [PATCH 4/4] ath10k: snoc: fix unbalanced clock error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wopqb2tr.fsf@kamboji.qca.qualcomm.com>
Date:   Tue, 06 Nov 2018 18:14:40 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Brian Norris <briannorris@...omium.org>,
        Govind Singh <govinds@...eaurora.org>,
        linux-wireless@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>, ath10k@...ts.infradead.org
Subject: Re: [PATCH 4/4] ath10k: snoc: fix unbalanced clock error handling

Doug Anderson <dianders@...omium.org> writes:

> Hi,
> On Fri, Oct 12, 2018 at 5:55 PM Brian Norris <briannorris@...omium.org> wrote:
>>
>> Similar to regulator error handling, we should only start tearing down
>> the 'i - 1' clock when clock 'i' fails to enable. Otherwise, we might
>> end up with an unbalanced clock, where we never successfully enabled the
>> clock, but we try to disable it anyway.
>>
>> Signed-off-by: Brian Norris <briannorris@...omium.org>
>
> Presumably you could have a Fixes tag just to help folks, like:
>
> Fixes: a6a793f98786 ("ath10k: vote for hardware resources for WCN3990")

Thanks, I added that in the pending branch.

-- 
Kalle Valo