linux-kernel - Re: [PATCH] acpi, nfit: Fix ARS overflow continuation

Open Source and information security mailing list archives

Message-ID: <a49e0427-1248-7844-bdc9-3c446b63d3f0@intel.com>
Date:   Tue, 6 Nov 2018 09:26:30 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Dan Williams <dan.j.williams@...el.com>, linux-nvdimm@...ts.01.org
Cc:     Jacek Zloch <jacek.zloch@...el.com>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] acpi, nfit: Fix ARS overflow continuation


On 11/6/18 9:05 AM, Dan Williams wrote:
> When the platform BIOS is unable to report all the media error records
> it requires the OS to restart the scrub at a prescribed location. The
> driver detects the overflow condition, but then fails to report it to
> the ARS state machine after reaping the records. Propagate -ENOSPC
> correctly to continue the ARS operation.
> 
> Cc: <stable@...r.kernel.org>
> Fixes: 1cf03c00e7c1 ("nfit: scrub and register regions in a workqueue")
> Reported-by: Jacek Zloch <jacek.zloch@...el.com>
> Signed-off-by: Dan Williams <dan.j.williams@...el.com>

Reviewed-by: Dave Jiang <dave.jiang@...el.com>

> ---
>  drivers/acpi/nfit/core.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index f8c638f3c946..5970b8f5f768 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -2928,9 +2928,9 @@ static int acpi_nfit_query_poison(struct acpi_nfit_desc *acpi_desc)
>  		return rc;
>  
>  	if (ars_status_process_records(acpi_desc))
> -		return -ENOMEM;
> +		dev_err(acpi_desc->dev, "Failed to process ARS records\n");
>  
> -	return 0;
> +	return rc;
>  }
>  
>  static int ars_register(struct acpi_nfit_desc *acpi_desc,
> 
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@...ts.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives