linux-kernel - Re: linux-4.20-rc1/arch/arm/vfp/vfpmodule.c:576: possible cut'n'paste error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77f6e853-2d6d-1149-f2f2-d23ddad6c611@arm.com>
Date:   Tue, 6 Nov 2018 16:29:54 +0000
From:   Julien Thierry <julien.thierry@....com>
To:     Russell King - ARM Linux <linux@...linux.org.uk>,
        David Binderman <dcb314@...mail.com>
Cc:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: linux-4.20-rc1/arch/arm/vfp/vfpmodule.c:576: possible cut'n'paste
 error

Hi Russel, David,

On 06/11/18 16:20, Russell King - ARM Linux wrote:
> On Mon, Nov 05, 2018 at 01:53:13PM +0000, David Binderman wrote:
>> Hello there,
>>
>> 2nd try. Plain text might help.
> 
> Yep, Linux kernel development generally doesn't like wasteful html
> emails, sorry.
> 
>> linux-4.20-rc1/arch/arm/vfp/vfpmodule.c:576]: (warning) Redundant assignment of 'ufp_exc->fpinst2' to itself.
>>
>> Source code is
>>
>>         ufp_exc->fpexc = hwstate->fpexc;
>>         ufp_exc->fpinst = hwstate->fpinst;
>>         ufp_exc->fpinst2 = ufp_exc->fpinst2;
> 
> Thanks for the report - it most certainly is a bug introduced by
> Julien's patches, but I don't get your warning here.  Which compiler
> produces that warning?
> 

Hmmm, silly typo/copy-paste from my end. Last line should be:

	ufp_exc->fpinst2 = hwstate->fpinst2;

Sorry about that.

> Julien - unfortunately, I've just asked Linus to take another fix
> for Spectre, so we're going to have to wait a bit before I can
> submit something for this.
> 

It is just a one line fix, should I submit a patch to the LAKML or patch 
system?
Otherwise let me know when is it best for you to receive the fix then to 
send to Linus.

Thanks,

-- 
Julien Thierry