linux-kernel - Re: [PATCH V3 6/6] usb: host: Add ability to build new Broadcom STB USB drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a2Xuq77sXKy4QX1YhStOEhm+oAM_AErEGuwqB115pHB_w@mail.gmail.com>
Date:   Tue, 6 Nov 2018 19:22:44 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Alan Cooper <alcooperx@...il.com>
Cc:     ": Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Alban Bedel <albeu@...e.fr>, Alex Elder <elder@...aro.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Avi Fishman <avifishman70@...il.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        chunfeng yun <chunfeng.yun@...iatek.com>,
        "David S. Miller" <davem@...emloft.net>,
        DTML <devicetree@...r.kernel.org>,
        Dmitry Osipenko <digetx@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Hans de Goede <hdegoede@...hat.com>,
        James Hogan <jhogan@...nel.org>,
        Jianguo Sun <sunjianguo1@...wei.com>,
        Johan Hovold <johan@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        USB list <linux-usb@...r.kernel.org>,
        Lu Baolu <baolu.lu@...ux.intel.com>,
        Mark Rutland <mark.rutland@....com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        Rishabh Bhatnagar <rishabhb@...eaurora.org>,
        Rob Herring <robh+dt@...nel.org>, Roger Quadros <rogerq@...com>
Subject: Re: [PATCH V3 6/6] usb: host: Add ability to build new Broadcom STB
 USB drivers

On 11/6/18, Alan Cooper <alcooperx@...il.com> wrote:
> On Tue, Nov 6, 2018 at 6:09 AM Arnd Bergmann <arnd@...db.de> wrote:
>>
>> On 11/5/18, Al Cooper <alcooperx@...il.com> wrote:
>>
>> > +
>> > +config USB_BRCM
>> > +     tristate "Broadcom STB USB support"
>> > +     depends on ARCH_BRCMSTB
>> > +     select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD
>> > +     select USB_EHCI_BRCM if USB_EHCI_HCD
>> > +     select USB_XHCI_BRCM if USB_XHCI_HCD
>> > +     select USB_XHCI_PLATFORM if USB_XHCI_HCD
>> > +     select BRCM_USB_PHY if USB_OHCI_HCD || USB_EHCI_HCD ||
>> > USB_XHCI_HCD
>> > +     select GENERIC_PHY if BRCM_USB_PHY
>> > +     default ARCH_BRCMSTB
>>
>> Is there a build time dependency on the PHY layer? If not, I would
>> suggest
>> dropping the last two 'select' statements. I would also suggest
>> making the dependency 'depends on ARCH_BRCMSTB || COMPILE_TEST'
>> to allow building it on other architecture for better build testing, and
>> dropping the 'default' line. Just add this to the defconfig like the
>> other
>> drivers you have.
>
> I added COMPILE_TEST and dropped the last 2 select lines.
> Most of our other drivers default to "y" for "ARCH_BRCMSTB", would it
> be better if I changed it to "default y"?

No, "default ARCH_BRCMSTB" is better than "default y", but I'd recommend
to just not have non-essential drivers default-on.

      Arnd