linux-kernel - Re: [RFC][PATCH] tree-wide: Remove __inline__ and _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wgTKDiDiQzoH=-ho1bn_SqvxHg+SEy1tQ_dSqqJJB5Rcw@mail.gmail.com>
Date:   Tue, 6 Nov 2018 11:51:35 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        bp@...en8.de, namit@...are.com, joe@...ches.com,
        Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
        segher@...nel.crashing.org, Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC][PATCH] tree-wide: Remove __inline__ and __inline usage

On Tue, Nov 6, 2018 at 11:42 AM Peter Zijlstra <peterz@...radead.org> wrote:
>
> Do you want me to do that patch, or have you already just done it?

I'd rather see it go through something like -tip than doing it myself
directly, and get at least some of the automated testing before
unleashing it on an unsuspecting world.

I don't think it will affect much, but there *could* be situations
where there are some crusty __inline__ users that actually want
__always_inline behavior.

And we *may* actually have cases where we want the "let compiler make
a judgement call" behavior, so with this change people will have that
as an option. But yes, in the short term, it has the possibility of
regressions due to missed inlining.

                Linus