linux-kernel - Re: [PATCH v1 4/4] xtensa: generate uapi header and syscall table header files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMo8BfJcUuC1tcrZNf+6_iRA0esj5QrGFViMMeR3NPw6G5GbFA@mail.gmail.com>
Date:   Tue, 6 Nov 2018 12:24:10 -0800
From:   Max Filippov <jcmvbkbc@...il.com>
To:     firoz.khan@...aro.org
Cc:     Arnd Bergmann <arnd@...db.de>, Chris Zankel <chris@...kel.net>,
        linux-xtensa@...ux-xtensa.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        y2038@...ts.linaro.org, LKML <linux-kernel@...r.kernel.org>,
        Linux-Arch <linux-arch@...r.kernel.org>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        marcin.juszkiewicz@...aro.org
Subject: Re: [PATCH v1 4/4] xtensa: generate uapi header and syscall table
 header files

Hi Firoz,

On Tue, Nov 6, 2018 at 7:12 AM Firoz Khan <firoz.khan@...aro.org> wrote:
> My initial patches does have generated-y += unistd_32.h instead of
> generic-y += unistd_32.h.
> If I remember someone pointed out that this implementation doesn't
> look good. So I
> replaced to generic-y += unistd_32.h.

I've only found the following case, where you did the replacement:
  https://lkml.org/lkml/2018/8/9/177
and I'm pretty sure that Michal meant that only the missing newline
didn't look good.

> Sure, I'll change to generated-y += unistd_32.h instead of generic-y
> += unistd_32.h.
>
> Max, this looks ok. right?

Yes, generated-y looks goodto me.
Could you also please move the line
  generated-y += syscall_table.h
up, so that alphabetical order of the header names is preserved?

--
Thanks.
-- Max