linux-kernel - Re: [PATCH] kernel/watchdog: add missing prototypes for weak functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+7wUsw0X541yTuG2t6-=3cDY9pjeA9yki10VgBRsVZB1hBLBA@mail.gmail.com>
Date:   Tue, 6 Nov 2018 21:35:35 +0100
From:   Mathieu Malaterre <malat@...ian.org>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Babu Moger <babu.moger@....com>
Subject: Re: [PATCH] kernel/watchdog: add missing prototypes for weak functions

ping ?
On Wed, Jun 6, 2018 at 9:42 PM Mathieu Malaterre <malat@...ian.org> wrote:
>
> In commit 73ce0511c436 ("kernel/watchdog.c: move hardlockup detector to
> separate file") two new functions were added ‘watchdog_nmi_enable’ and
> ‘watchdog_nmi_disable’ the functions were changed from static to weak.
> In which case expose the function declarations in header file.
>
> Silence the following gcc warnings:
>
>   kernel/watchdog.c:109:12: warning: no previous prototype for ‘watchdog_nmi_enable’ [-Wmissing-prototypes]
>   kernel/watchdog.c:115:13: warning: no previous prototype for ‘watchdog_nmi_disable’ [-Wmissing-prototypes]
>
> Cc: Babu Moger <babu.moger@...cle.com>
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> ---
>  include/linux/nmi.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/nmi.h b/include/linux/nmi.h
> index b8d868d23e79..50d143995338 100644
> --- a/include/linux/nmi.h
> +++ b/include/linux/nmi.h
> @@ -113,6 +113,8 @@ static inline int hardlockup_detector_perf_init(void) { return 0; }
>  void watchdog_nmi_stop(void);
>  void watchdog_nmi_start(void);
>  int watchdog_nmi_probe(void);
> +int watchdog_nmi_enable(unsigned int cpu);
> +void watchdog_nmi_disable(unsigned int cpu);
>
>  /**
>   * touch_nmi_watchdog - restart NMI watchdog timeout.
> --
> 2.11.0
>