linux-kernel - Re: [PATCH] cpuset: remove set but not used variable 'cs'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7ac28cbe-56ec-3564-15fd-94acb4687150@oracle.com>
Date:   Wed, 7 Nov 2018 15:08:36 -0700
From:   Tom Hromatka <tom.hromatka@...cle.com>
To:     Yi Wang <wang.yi59@....com.cn>, lizefan@...wei.com
Cc:     cgroups@...r.kernel.org, linux-kernel@...r.kernel.org,
        zhong.weidong@....com.cn
Subject: Re: [PATCH] cpuset: remove set but not used variable 'cs'

On 11/07/2018 12:18 AM, Yi Wang wrote:
> This fixes the following warning:
> kernel/cgroup/cpuset.c: In function ‘cpuset_cancel_attach’:
> kernel/cgroup/cpuset.c:1501:17: warning: variable ‘cs’ set but not used [-Wunused-but-set-variable]
>    struct cpuset *cs;
>                   ^
> 
> Signed-off-by: Yi Wang <wang.yi59@....com.cn>


Reviewed-by: Tom Hromatka <tom.hromatka@...cle.com>


> ---
>   kernel/cgroup/cpuset.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index 266f10c..784f948 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -1498,10 +1498,8 @@ static int cpuset_can_attach(struct cgroup_taskset *tset)
>   static void cpuset_cancel_attach(struct cgroup_taskset *tset)
>   {
>   	struct cgroup_subsys_state *css;
> -	struct cpuset *cs;
>   
>   	cgroup_taskset_first(tset, &css);
> -	cs = css_cs(css);
>   
>   	mutex_lock(&cpuset_mutex);
>   	css_cs(css)->attach_in_progress--;
>