linux-kernel - Re: [PATCH 3/3] drivers/char/random.c: make primary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181107221148.GC17171@thunk.org>
Date:   Wed, 7 Nov 2018 17:11:48 -0500
From:   "Theodore Y. Ts'o" <tytso@....edu>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] drivers/char/random.c: make primary_crng static

On Fri, Nov 02, 2018 at 12:04:47PM +0100, Rasmus Villemoes wrote:
> Since the definition of struct crng_state is private to random.c, and
> primary_crng is neither declared or used elsewhere, there's no reason
> for that symbol to have external linkage.
> 
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>

Thanks, applied.

					- Ted